Fix two uninitialized variables
Found when running in valgrind looking at another issue.
- RenderPass' depth_stencil_target
Tripped in SDL_BindGPUFragmentSamplers when not binding a DS target
- VulkanCommandBuffer's swapchainRequested
Tripped in VULKAN_Submit for the end transition barrier when
creating an image. The field is only reset when reused, not on first
use
This commit is contained in:
committed by
Sam Lantinga
parent
fdfde42db1
commit
265236d952
@@ -1779,6 +1779,8 @@ SDL_GPURenderPass *SDL_BeginGPURenderPass(
|
|||||||
commandBufferHeader->render_pass.num_color_targets = num_color_targets;
|
commandBufferHeader->render_pass.num_color_targets = num_color_targets;
|
||||||
if (depth_stencil_target_info != NULL) {
|
if (depth_stencil_target_info != NULL) {
|
||||||
commandBufferHeader->render_pass.depth_stencil_target = depth_stencil_target_info->texture;
|
commandBufferHeader->render_pass.depth_stencil_target = depth_stencil_target_info->texture;
|
||||||
|
} else {
|
||||||
|
commandBufferHeader->render_pass.depth_stencil_target = NULL;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -9408,6 +9408,8 @@ static bool VULKAN_INTERNAL_AllocateCommandBuffer(
|
|||||||
commandBuffer->usedUniformBuffers = SDL_malloc(
|
commandBuffer->usedUniformBuffers = SDL_malloc(
|
||||||
commandBuffer->usedUniformBufferCapacity * sizeof(VulkanUniformBuffer *));
|
commandBuffer->usedUniformBufferCapacity * sizeof(VulkanUniformBuffer *));
|
||||||
|
|
||||||
|
commandBuffer->swapchainRequested = false;
|
||||||
|
|
||||||
// Pool it!
|
// Pool it!
|
||||||
|
|
||||||
vulkanCommandPool->inactiveCommandBuffers[vulkanCommandPool->inactiveCommandBufferCount] = commandBuffer;
|
vulkanCommandPool->inactiveCommandBuffers[vulkanCommandPool->inactiveCommandBufferCount] = commandBuffer;
|
||||||
|
|||||||
Reference in New Issue
Block a user