gitea/SDL3_fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't use alloca() in a loop, we might overflow the stack.

Browse Source
This commit is contained in:
Sam Lantinga
2024-08-02 21:33:42 -07:00
parent 978e5fc4f8
commit 2c0fcf27e8
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/video/windows/SDL_windowswindow.c
View File

@@ -2091,9 +2091,8 @@ static STDMETHODIMP SDLDropTarget_Drop(SDLDropTarget *target,
fetc.cfFormat, format_mime, (unsigned long)bsize, drop); fetc.cfFormat, format_mime, (unsigned long)bsize, drop);
UINT count = DragQueryFile(drop, 0xFFFFFFFF, NULL, 0); UINT count = DragQueryFile(drop, 0xFFFFFFFF, NULL, 0);
for (UINT i = 0; i < count; ++i) { for (UINT i = 0; i < count; ++i) {
SDL_bool isstack;
UINT size = DragQueryFile(drop, i, NULL, 0) + 1; UINT size = DragQueryFile(drop, i, NULL, 0) + 1;
LPTSTR buffer = SDL_small_alloc(TCHAR, size, &isstack); LPTSTR buffer = (LPTSTR)SDL_malloc(size * sizeof(TCHAR));
if (buffer) { if (buffer) {
if (DragQueryFile(drop, i, buffer, size)) { if (DragQueryFile(drop, i, buffer, size)) {
char *file = WIN_StringToUTF8(buffer); char *file = WIN_StringToUTF8(buffer);
@@ -2103,7 +2102,7 @@ static STDMETHODIMP SDLDropTarget_Drop(SDLDropTarget *target,
SDL_SendDropFile(target->window, NULL, file); SDL_SendDropFile(target->window, NULL, file);
SDL_free(file); SDL_free(file);
} }
SDL_small_free(buffer, isstack); SDL_free(buffer);
} }
} }
GlobalUnlock(med.hGlobal); GlobalUnlock(med.hGlobal);