gitea/SDL3_fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

audio: Fixed potential NULL dereference.

Browse Source 
This could happen if you call SDL_BindAudioStreams() when the subsystem isn't
initialized, and possibly in other corner cases.

Thanks to Qianxin CodeSafe Team, @QiAnXinCodeSafe, for discovering this issue!

Fixes #11643.
This commit is contained in:
Ryan C. Gordon
2024-12-13 10:10:19 -05:00
parent 1944bc7407
commit 80b9986418
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/audio/SDL_audio.c
View File

@@ -234,6 +234,10 @@ static bool AudioDeviceCanUseSimpleCopy(SDL_AudioDevice *device)
// should hold device->lock before calling. // should hold device->lock before calling.
static void UpdateAudioStreamFormatsPhysical(SDL_AudioDevice *device) static void UpdateAudioStreamFormatsPhysical(SDL_AudioDevice *device)
{ {
if (!device) {
return;
}
if (device->recording) { // for recording devices, we only want to move to float32 for postmix and gain, which we'll handle elsewhere. if (device->recording) { // for recording devices, we only want to move to float32 for postmix and gain, which we'll handle elsewhere.
// we _do_ need to make sure the channel map is correct, though... // we _do_ need to make sure the channel map is correct, though...
for (SDL_LogicalAudioDevice *logdev = device->logical_devices; logdev; logdev = logdev->next) { for (SDL_LogicalAudioDevice *logdev = device->logical_devices; logdev; logdev = logdev->next) {