gitea/SDL3_fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dummyaudio: Remove bitrotted support for __EMSCRIPTEN_PTHREADS__ code path.

Browse Source 
In SDL_audio.c:OpenPhysicalAudioDevice, an attempt is made to SDL_CreateThread
if ProvidesOwnCallbackThread is false, but SDL_CreateThreadWithPropertiesRuntime
is not implemented for Emscripten, so this always fails. I'm not sure if/when
this ever worked, but it simply cannot work in its current state.
This commit is contained in:
William Horvath
2026-02-07 22:06:14 -08:00
committed by Sam Lantinga
parent c15ca27740
commit 8ee7dc2f9f
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/audio/dummy/SDL_dummyaudio.c
View File

@@ -25,7 +25,7 @@
#include "../SDL_sysaudio.h" #include "../SDL_sysaudio.h"
#include "SDL_dummyaudio.h" #include "SDL_dummyaudio.h"
#if defined(SDL_PLATFORM_EMSCRIPTEN) && !defined(__EMSCRIPTEN_PTHREADS__) #if defined(SDL_PLATFORM_EMSCRIPTEN)
#include <emscripten/emscripten.h> #include <emscripten/emscripten.h>
#endif #endif
@@ -59,8 +59,8 @@ static bool DUMMYAUDIO_OpenDevice(SDL_AudioDevice *device)
} }
} }
// on Emscripten without threads, we just fire a repeating timer to consume audio. // on Emscripten, we just fire a repeating timer to consume audio.
#if defined(SDL_PLATFORM_EMSCRIPTEN) && !defined(__EMSCRIPTEN_PTHREADS__) #if defined(SDL_PLATFORM_EMSCRIPTEN)
MAIN_THREAD_EM_ASM({ MAIN_THREAD_EM_ASM({
var a = Module['SDL3'].dummy_audio; var a = Module['SDL3'].dummy_audio;
if (a.timers[$0] !== undefined) { clearInterval(a.timers[$0]); } if (a.timers[$0] !== undefined) { clearInterval(a.timers[$0]); }
@@ -74,8 +74,8 @@ static bool DUMMYAUDIO_OpenDevice(SDL_AudioDevice *device)
static void DUMMYAUDIO_CloseDevice(SDL_AudioDevice *device) static void DUMMYAUDIO_CloseDevice(SDL_AudioDevice *device)
{ {
if (device->hidden) { if (device->hidden) {
// on Emscripten without threads, we just fire a repeating timer to consume audio. // on Emscripten, we just fire a repeating timer to consume audio.
#if defined(SDL_PLATFORM_EMSCRIPTEN) && !defined(__EMSCRIPTEN_PTHREADS__) #if defined(SDL_PLATFORM_EMSCRIPTEN)
MAIN_THREAD_EM_ASM({ MAIN_THREAD_EM_ASM({
var a = Module['SDL3'].dummy_audio; var a = Module['SDL3'].dummy_audio;
if (a.timers[$0] !== undefined) { clearInterval(a.timers[$0]); } if (a.timers[$0] !== undefined) { clearInterval(a.timers[$0]); }
@@ -113,8 +113,8 @@ static bool DUMMYAUDIO_Init(SDL_AudioDriverImpl *impl)
impl->OnlyHasDefaultRecordingDevice = true; impl->OnlyHasDefaultRecordingDevice = true;
impl->HasRecordingSupport = true; impl->HasRecordingSupport = true;
// on Emscripten without threads, we just fire a repeating timer to consume audio. // on Emscripten, we just fire a repeating timer to consume audio.
#if defined(SDL_PLATFORM_EMSCRIPTEN) && !defined(__EMSCRIPTEN_PTHREADS__) #if defined(SDL_PLATFORM_EMSCRIPTEN)
MAIN_THREAD_EM_ASM({ MAIN_THREAD_EM_ASM({
Module['SDL3'].dummy_audio = {}; Module['SDL3'].dummy_audio = {};
Module['SDL3'].dummy_audio.timers = []; Module['SDL3'].dummy_audio.timers = [];