gitea/SDL3_fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

rwlock: SDL_UnlockRWLock was incorrectly tagged with SDL_RELEASE_SHARED.

Browse Source 
It needs to be SDL_RELEASE_GENERIC, because it releases both exclusive
(writer) and shared (reader) locks.

Without this fix, clang's `-Wthread-safety` tests generate incorrect warnings.

Reference Issue #8096.
This commit is contained in:
Ryan C. Gordon
2023-10-24 14:42:02 -04:00
parent 865dd04068
commit b16165a33f
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
include/SDL3/SDL_mutex.h
View File

@@ -433,7 +433,7 @@ extern DECLSPEC int SDLCALL SDL_TryLockRWLockForWriting(SDL_RWLock *rwlock) SDL_
* *
* \since This function is available since SDL 3.0.0. * \since This function is available since SDL 3.0.0.
*/ */
extern DECLSPEC int SDLCALL SDL_UnlockRWLock(SDL_RWLock *rwlock) SDL_RELEASE_SHARED(rwlock); extern DECLSPEC int SDLCALL SDL_UnlockRWLock(SDL_RWLock *rwlock) SDL_RELEASE_GENERIC(rwlock);
/** /**
* Destroy a read/write lock created with SDL_CreateRWLock(). * Destroy a read/write lock created with SDL_CreateRWLock().