gitea/SDL3_fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

wasapi: fix memory leak on unlikely failure case.

Browse Source
This commit is contained in:
Ryan C. Gordon
2025-11-03 10:10:52 -05:00
parent 7db0e48454
commit d66946cee7
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/core/windows/SDL_immdevice.c
View File

@@ -156,7 +156,7 @@ static SDL_AudioDevice *SDL_IMMDevice_Add(const bool recording, const char *devn
SDL_free(handle); SDL_free(handle);
return NULL; return NULL;
} }
SDL_copyp(&handle->directsound_guid, &dsoundguid); SDL_copyp(&handle->directsound_guid, dsoundguid);
SDL_AudioSpec spec; SDL_AudioSpec spec;
SDL_zero(spec); SDL_zero(spec);
@@ -173,10 +173,16 @@ static SDL_AudioDevice *SDL_IMMDevice_Add(const bool recording, const char *devn
return NULL; return NULL;
} }
SDL_memcpy(&recording_handle->directsound_guid, dsoundguid, sizeof(GUID));
recording_handle->immdevice_id = SDL_wcsdup(devid); recording_handle->immdevice_id = SDL_wcsdup(devid);
if (!recording_handle->immdevice_id) {
SDL_free(recording_handle);
return NULL;
}
if (!recording_handle->immdevice_id || !SDL_AddAudioDevice(true, devname, &spec, recording_handle)) { SDL_copyp(&recording_handle->directsound_guid, dsoundguid);
if (!SDL_AddAudioDevice(true, devname, &spec, recording_handle)) {
SDL_free(recording_handle->immdevice_id);
SDL_free(recording_handle); SDL_free(recording_handle);
} }
} }