From f3c466ec1ea5a312f606d1a91e92996c64a567c5 Mon Sep 17 00:00:00 2001 From: Markus Mittendrein Date: Sun, 27 Nov 2022 22:46:54 +0100 Subject: [PATCH] SDL_ResampleAudio: Fix float accumulation error While 78f97108f9dad22db6708f28322561eb9828fc36 reduced the accumulation error, it was still big enough to cause distortions. Fixes #6196. (cherry picked from commit 8145212103264b04c20cdb50b430f3c99b44e9b4) --- src/audio/SDL_audiocvt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/audio/SDL_audiocvt.c b/src/audio/SDL_audiocvt.c index 8ca5fa99f..884d7836b 100644 --- a/src/audio/SDL_audiocvt.c +++ b/src/audio/SDL_audiocvt.c @@ -198,7 +198,6 @@ SDL_ResampleAudio(const int chans, const int inrate, const int outrate, typedef float ResampleFloatType; const ResampleFloatType finrate = (ResampleFloatType) inrate; - const ResampleFloatType outtimeincr = ((ResampleFloatType) 1.0f) / ((ResampleFloatType) outrate); const ResampleFloatType ratio = ((float) outrate) / ((float) inrate); const int paddinglen = ResamplerPadding(inrate, outrate); const int framelen = chans * (int)sizeof (float); @@ -243,7 +242,7 @@ SDL_ResampleAudio(const int chans, const int inrate, const int outrate, *(dst++) = outsample; } - outtime = outtimeincr * i; + outtime = ((ResampleFloatType) i) / ((ResampleFloatType) outrate); } return outframes * chans * sizeof(float);